0000977: VLAN field in node table should be re-thought - PacketFence

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000977

PacketFence

refactoring

public

2010-05-04 16:49

2011-01-26 15:42

Reporter

obilodeau

Assigned To

obilodeau

Priority

normal

Severity

minor

Reproducibility

N/A

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

2.0.0

Fixed in Version

2.0.0

Summary

0000977: VLAN field in node table should be re-thought

Description

The node view field is useful for admins to get a quick overview of what node is in what state and in what vlan.

Right now the vlan field in node table is not kept accurate by PacketFence beccause it was historically used for vlan assignation. Also, we generally recommend people needing per-node VLAN assignments to override vlan.pm and return $vlan (or more recently $node_info->{vlan}) to assign VLANs. Because of that we can't override the node.vlan field without causing adverse effects on current customers.

We should rename the vlan field there to target_vlan or something (check with Regis) and drop the vlan field. The node view should join on the locationlog table and show that information for VLAN info (which is kept accurate).

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

8116f6f5657fa9232ce57c50c926e66f23abe079

Attached Files

Relationships

related to	0000914	closed	obilodeau	node table should not carry data duplicated from locationlog
related to	0001082	closed		Specify a VLAN per node
parent of	0000927	closed	obilodeau	VLAN field in node view should be re-labeled

Notes
(0001704) obilodeau (reporter) 2010-09-30 18:58	node.vlan is now node.bypass_vlan. It is not enforced by default. You will need to override get_normal_vlan in pf::vlan::custom. See pf::vlan's get_normal_vlan for an example usage. Issue 0001082 will enable that behavior by default. Fix in trunk. Database changes were required.

Issue History
Date Modified	Username	Field	Change
2010-05-04 16:49	obilodeau	New Issue
2010-05-04 16:49	obilodeau	Status	new => assigned
2010-05-04 16:49	obilodeau	Assigned To	=> obilodeau
2010-05-04 16:49	obilodeau	Relationship added	parent of 0000927
2010-05-04 16:49	obilodeau	Relationship added	related to 0000914
2010-09-29 17:25	obilodeau	Relationship added	related to 0001082
2010-09-30 18:58	obilodeau	mtn revision	=> 8116f6f5657fa9232ce57c50c926e66f23abe079
2010-09-30 18:58	obilodeau	Note Added: 0001704
2010-09-30 18:58	obilodeau	Status	assigned => resolved
2010-09-30 18:58	obilodeau	Fixed in Version	=> trunk
2010-09-30 18:58	obilodeau	Resolution	open => fixed
2010-11-19 14:25	obilodeau	Target Version	1.10.0 => 2.0.0
2010-12-15 11:37	obilodeau	Fixed in Version	trunk => 2.0.0
2011-01-26 15:42	obilodeau	Status	resolved => closed