0001322: Slash in PID - PacketFence

(0002414)
bonald (reporter)
2011-11-01 10:51

not the best way but this will remove the error
$user_name =~ s/\//./g;

Add this to radius.pm line 219

It will replace / with .

(0002422)
obilodeau (reporter)
2011-11-02 10:37

A radius-based work-around is also possible:
- use a realm that would strip the User-Name properly (/etc/raddb/modules/realm)
- override _parseRequest in lib/pf/radius/custom.pm to use Stripped-User-Name instead of User-Name

The advantage of the above work-around is that you will not loose it on upgrades. It's using stable extension points.

Deciding what's a proper pid (characters allowed) is the scope for a larger design problem we intend to solve down the road.

(0002423)
obilodeau (reporter)
2011-11-02 15:13

Ok, we looked into it today and we decided that we are going to fix this. Hang on, it'll be fixed eventually. Meanwhile keep your s///g workaround.

(0002424)
obilodeau (reporter)
2011-11-03 12:27

Fixed in trunk will be released in our next 'major' version which should be soon anyways.

(0002506)
obilodeau (reporter)
2011-12-30 23:40

Released in version 3.1.0.

Issue History
Date Modified	Username	Field	Change
2011-11-01 10:28	bonald	New Issue
2011-11-01 10:51	bonald	Note Added: 0002414
2011-11-02 10:37	obilodeau	Note Added: 0002422
2011-11-02 15:13	obilodeau	Note Added: 0002423
2011-11-03 11:02	obilodeau	Status	new => assigned
2011-11-03 11:02	obilodeau	Assigned To	=> obilodeau
2011-11-03 12:27	obilodeau	mtn revision	=> 8caa27e9c6243bc7cd90159207e8ba9461d16271
2011-11-03 12:27	obilodeau	Note Added: 0002424
2011-11-03 12:27	obilodeau	Status	assigned => resolved
2011-11-03 12:27	obilodeau	Fixed in Version	=> trunk
2011-11-03 12:27	obilodeau	Resolution	open => fixed
2011-12-30 23:28	obilodeau	Fixed in Version	trunk => 3.1.0
2011-12-30 23:40	obilodeau	Note Added: 0002506
2011-12-30 23:44	obilodeau	Status	resolved => closed

Notes
(0002414) bonald (reporter) 2011-11-01 10:51	not the best way but this will remove the error $user_name =~ s/\//./g; Add this to radius.pm line 219 It will replace / with .

(0002422) obilodeau (reporter) 2011-11-02 10:37	A radius-based work-around is also possible: - use a realm that would strip the User-Name properly (/etc/raddb/modules/realm) - override _parseRequest in lib/pf/radius/custom.pm to use Stripped-User-Name instead of User-Name The advantage of the above work-around is that you will not loose it on upgrades. It's using stable extension points. Deciding what's a proper pid (characters allowed) is the scope for a larger design problem we intend to solve down the road.

(0002423) obilodeau (reporter) 2011-11-02 15:13	Ok, we looked into it today and we decided that we are going to fix this. Hang on, it'll be fixed eventually. Meanwhile keep your s///g workaround.

(0002424) obilodeau (reporter) 2011-11-03 12:27	Fixed in trunk will be released in our next 'major' version which should be soon anyways.

(0002506) obilodeau (reporter) 2011-12-30 23:40	Released in version 3.1.0.

Relationships