0001405: pfsetvlan trap_limit feature problematic behavior - PacketFence

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001405

PacketFence

core

public

2012-03-26 12:10

2012-04-23 11:01

Reporter

dwuelfrath

Assigned To

obilodeau

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

devel

Target Version

3.3.2

Fixed in Version

3.3.2

Summary

0001405: pfsetvlan trap_limit feature problematic behavior

Description

Even if no action is configured in [vlan.trap_limit_action], when [vlan.trap_limit_threshold] is reached for any switch (even 127.0.0.1) the trap processing is aborted.

Additional Information

# skip traps coming from switch ifIndex that reached traps limit threshold
            if ( defined($trapHashRef->{'trapIfIndex'})
                    && isenabled($Config{'vlan'}{'trap_limit'})
                    && check_traps_limit_threshold($switch, $trapHashRef->{'trapIfIndex'}) ) {
                $logger->warn("We received too many traps (over $Config{'vlan'}{'trap_limit_threshold'}) in a minute) "
                        . "from ifIndex $trapHashRef->{'trapIfIndex'} of switch $switch->{_ip}");
            # skip unknown traps
            } elsif ( $trapType ne 'unknown' ) {

Tags

No tags attached.

fixed in git revision

251e6a839f5b36db3c1e8919d5a07674ed3d1195

fixed in mtn revision

Attached Files

Relationships

Notes
(0002624) dwuelfrath (administrator) 2012-03-26 12:13	When the first if statement is true, workflow skips the elsif. Should detach the if statement from the rest of the process but without interfering with the trap_limit workflow. Should also make sure to not act on local traps.

(0002676) obilodeau (reporter) 2012-04-20 14:47	Fix developed in branch: fix/1405-trap-limit-behavior, merged in stable.

(0002684) obilodeau (reporter) 2012-04-23 11:01	fix released in 3.3.2

Issue History
Date Modified	Username	Field	Change
2012-03-26 12:10	dwuelfrath	New Issue
2012-03-26 12:13	dwuelfrath	Note Added: 0002624
2012-04-18 11:19	obilodeau	Target Version	trunk => +1
2012-04-20 14:47	obilodeau	git revision	=> 251e6a839f5b36db3c1e8919d5a07674ed3d1195
2012-04-20 14:47	obilodeau	Note Added: 0002676
2012-04-20 14:47	obilodeau	Status	new => resolved
2012-04-20 14:47	obilodeau	Fixed in Version	=> +1
2012-04-20 14:47	obilodeau	Resolution	open => fixed
2012-04-20 14:47	obilodeau	Assigned To	=> obilodeau
2012-04-23 11:00	obilodeau	Target Version	+1 => 3.3.2
2012-04-23 11:00	obilodeau	Fixed in Version	+1 => 3.3.2
2012-04-23 11:01	obilodeau	Note Added: 0002684
2012-04-23 11:01	obilodeau	Status	resolved => closed