0001540: pf::scan will try to instanciate unknown module - PacketFence - BTS

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0001540

PacketFence

scanning

public

2012-09-06 08:58

2012-09-06 11:05

Reporter

dwuelfrath

Assigned To

dwuelfrath

Priority

low

Severity

minor

Reproducibility

always

Status

acknowledged

Resolution

open

Platform

OS

OS Version

Product Version

Target Version

Fixed in Version

Summary

0001540: pf::scan will try to instanciate unknown module

Description

Even if we do a check if the scanning type exist or not, we do not handle the result and continue the workflow.

Additional Information

https://github.com/inverse-inc/packetfence/blob/stable/lib/pf/scan.pm#L93 [^]

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

Relationships

Notes
(0003028) obilodeau (reporter) 2012-09-06 11:01	Another thing to look at: https://github.com/inverse-inc/packetfence/blob/stable/lib/pf/scan.pm#L165 [^]

(0003029) obilodeau (reporter) 2012-09-06 11:05	Ok, pf::scan's run_scan is never checked for success or not. Also scans are initiated explicitly by bin/pfcmd and never inside daemons so the crash wouldn't be as bad as causing a daemon to crash. That said, it could introduce subtle mistake if we ever decide start scans inside daemons or long term processes like apache so it should be fixed.

Issue History
Date Modified	Username	Field	Change
2012-09-06 08:58	dwuelfrath	New Issue
2012-09-06 08:59	dwuelfrath	Assigned To	=> dwuelfrath
2012-09-06 08:59	dwuelfrath	Status	new => acknowledged
2012-09-06 08:59	dwuelfrath	Target Version	=> +1
2012-09-06 11:01	obilodeau	Note Added: 0003028
2012-09-06 11:05	obilodeau	Note Added: 0003029
2012-09-06 11:05	obilodeau	Priority	normal => low
2012-09-06 11:05	obilodeau	Severity	major => minor

Copyright © 2000 - 2012 MantisBT Group