0000856: Cisco's getVlan with unknown ifIndex returns undef - PacketFence - BTS

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0000856

PacketFence

error-handling

public

2009-11-18 13:23

2015-02-13 15:26

Reporter

obilodeau

Assigned To

obilodeau

Priority

high

Severity

minor

Reproducibility

always

Status

closed

Resolution

open

Platform

OS

OS Version

Product Version

Target Version

Fixed in Version

Summary

0000856: Cisco's getVlan with unknown ifIndex returns undef

Description

around line 367 in lib/pf/SNMP/Cisco.pm, added a TODO task

task in code at rev no: 17bc0fbf8af80db10c3bcb5af6dda2d404c4b35a

check parent bug for how to resolve

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

0000856_v1.patch [^] (1,245 bytes) 2011-04-12 15:29 [Show Content] [Hide Content]

#
# old_revision [f82fb323220b275d3dc05b3c34d5fca44248eb46]
#
# patch "pf/lib/pf/SNMP/Cisco.pm"
#  from [629111f8e99f81b7c824341c4a569f4e18406375]
#    to [7f7754ad44436330b25a9dba7c729192f2216a20]
#
============================================================
--- pf/lib/pf/SNMP/Cisco.pm	629111f8e99f81b7c824341c4a569f4e18406375
+++ pf/lib/pf/SNMP/Cisco.pm	7f7754ad44436330b25a9dba7c729192f2216a20
@@ -374,8 +374,6 @@ sub getVoiceVlan {
     }
 }
 
-# TODO: if ifIndex doesn't exist, an error should be given
-# to reproduce: bin/pfcmd_vlan -getVlan -ifIndex 999 -switch <ip>
 sub getVlan {
     my ( $this, $ifIndex ) = @_;
     my $logger = Log::Log4perl::get_logger( ref($this) );
@@ -401,7 +399,12 @@ sub getVlan {
         );
         my $result = $this->{_sessionRead}->get_request(
             -varbindlist => ["$OID_vlanTrunkPortNativeVlan.$ifIndex"] );
-        return $result->{"$OID_vlanTrunkPortNativeVlan.$ifIndex"};
+        
+        return (
+            exists ( $result->{"$OID_vlanTrunkPortNativeVlan.$ifIndex"} )
+                && ( $result->{"$OID_vlanTrunkPortNativeVlan.$ifIndex"} ne 'noSuchInstance' )
+                && ( $result->{"$OID_vlanTrunkPortNativeVlan.$ifIndex"} ne 'noSuchObject' )
+        );
     }
 }

0000856_v2.patch [^] (1,244 bytes) 2011-04-12 15:29 [Show Content] [Hide Content]

#
# old_revision [f82fb323220b275d3dc05b3c34d5fca44248eb46]
#
# patch "pf/lib/pf/SNMP/Cisco.pm"
#  from [629111f8e99f81b7c824341c4a569f4e18406375]
#    to [b6eed740c943fecaeec3d055e1a5fb6737f42799]
#
============================================================
--- pf/lib/pf/SNMP/Cisco.pm	629111f8e99f81b7c824341c4a569f4e18406375
+++ pf/lib/pf/SNMP/Cisco.pm	b6eed740c943fecaeec3d055e1a5fb6737f42799
@@ -374,8 +374,6 @@ sub getVoiceVlan {
     }
 }
 
-# TODO: if ifIndex doesn't exist, an error should be given
-# to reproduce: bin/pfcmd_vlan -getVlan -ifIndex 999 -switch <ip>
 sub getVlan {
     my ( $this, $ifIndex ) = @_;
     my $logger = Log::Log4perl::get_logger( ref($this) );
@@ -401,7 +399,15 @@ sub getVlan {
         );
         my $result = $this->{_sessionRead}->get_request(
             -varbindlist => ["$OID_vlanTrunkPortNativeVlan.$ifIndex"] );
-        return $result->{"$OID_vlanTrunkPortNativeVlan.$ifIndex"};
+        
+        if (!$result) {
+            $logger->trace(
+                "SNMP get_vlanTrunkNativeVlan failed for ifIndex $ifIndex, the ifIndex is probably invalid"
+            );
+            return 0;
+        }
+        
+        return  $result->{"$OID_vlanTrunkPortNativeVlan.$ifIndex"};
     }
 }

Relationships

child of

closed

SNMP subs error-handling/exceptions

Notes
(0002027) fgaudreault (viewer) 2011-04-12 15:30	Two patches possible, choose the one you prefer : - V1: This will return $result only if the value exists - V2: This will check if $result, log and return 0 if not existing.

(0002037) obilodeau (reporter) 2011-04-21 17:50 edited on: 2011-04-21 17:51	Here the problem is not to return a different value but to prevent callers from doing something stupid. All callers should be validated and proper error handling be put in place upstream. Not ready for review since we don't know the impact of such a change at the moment.

(0003729) lmunro (administrator) 2015-02-13 15:26	Old issues. Most are not relevant to PF 4 and up. Let's reopen the ones that matter when we move to github.

Issue History
Date Modified	Username	Field	Change
2009-11-18 13:23	obilodeau	New Issue
2009-11-18 13:23	obilodeau	Status	new => assigned
2009-11-18 13:23	obilodeau	Assigned To	=> obilodeau
2009-11-18 13:23	obilodeau	Relationship added	child of 0000855
2010-04-15 17:43	obilodeau	Project	PacketFence 1.9 => PacketFence
2011-01-18 11:41	obilodeau	Target Version	=> 2.1.0
2011-03-03 15:15	obilodeau	Target Version	2.1.0 => +1
2011-03-03 15:18	obilodeau	Target Version	+1 => +2
2011-04-12 15:29	fgaudreault	File Added: 0000856_v1.patch
2011-04-12 15:29	fgaudreault	File Added: 0000856_v2.patch
2011-04-12 15:30	fgaudreault	Note Added: 0002027
2011-04-12 15:30	fgaudreault	Tag Attached: Code Review
2011-04-21 17:50	obilodeau	Note Added: 0002037
2011-04-21 17:51	obilodeau	Tag Detached: Code Review
2011-04-21 17:51	obilodeau	Note Edited: 0002037
2015-02-13 15:26	lmunro	Note Added: 0003729
2015-02-13 15:26	lmunro	Status	assigned => closed

Copyright © 2000 - 2012 MantisBT Group